This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 03/18] Do not stack-protect ifunc resolvers.
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: Nix <nix at esperi dot org dot uk>, <libc-alpha at sourceware dot org>
- Date: Thu, 10 Mar 2016 00:23:36 +0000
- Subject: Re: [PATCH 03/18] Do not stack-protect ifunc resolvers.
- Authentication-results: sourceware.org; auth=none
- References: <1457445064-7107-1-git-send-email-nix at esperi dot org dot uk> <1457445064-7107-4-git-send-email-nix at esperi dot org dot uk> <20160309224010 dot GD6588 at vapier dot lan>
On Wed, 9 Mar 2016, Mike Frysinger wrote:
> On 08 Mar 2016 13:50, Nix wrote:
> > +AC_CACHE_CHECK(if $CC accepts -fno-stack-protector with \
> > +__attribute__ ((__optimize__)),
>
> m4 strings should be quoted. so this should be:
> AC_CACHE_CHECK([if $CC ........], ...
It would certainly be nice if someone cleaned up the existing *.ac scripts
and fragments to consistently follow this rule (for each autoconf macro,
there should generally be exactly one level of [] quoting around each of
its arguments, except in special cases such as where the Autoconf manual
explains that AC_LANG_SOURCE's argument should be double-quoted [[]]).
--
Joseph S. Myers
joseph@codesourcery.com