Re: [PATCH] Fix building glibc master with NDEBUG.

[Carlos O'Donell <carlos at redhat dot com>]

On 03/11/2016 03:44 AM, Florian Weimer wrote:
> On 03/11/2016 03:29 AM, Carlos O'Donell wrote:
> 
>>         * catgets/tst-catgets.c (do_bz17905): Mark result unused.
>>         * dlfcn/bug-dl-leaf-lib.c (check_val_fini): Mark ret unused.
>>         * math/atest-exp.c (exp_mpn): Mark chk unused.
>>         * math/atest-exp2.c (exp_mpn): Likwise.
> 
> Tests should not use assert because it writes the message to standard
> error, not standard output, where it is captured.  We can add a
> different macro to test-skeleton.c for this purpose.  It would be useful
> in many cases.

For now I'm not going to remove the test asserts.

If we changes asserts in tests then it has to be by reviewing what
information the assert provides, and replacing it with something
meaningful for the test at hand. If the assert is triggering it means
some precondition of the test is being violated and that really needs to
be checked *always*.

I wonder if Arjun's scripts can help find all such asserts and possibly
do an automatic transformation (he did test-skeleton.c conversions with
a set of scripts). Arjun?

>>         * sysdeps/arm/dl-machine.h (elf_machine_rela): Mark td unused.
> 
> This seems okay.

OK.

>>         * sysdeps/i386/i686/dl-hash.h: Mark _dl_elf_hash unused.
> 
> This one is not related to NDEBUG, I think, but to --with-cpu.

You're absolutely right. I'll adjust my commit message to mention taht.

-- 
Cheers,
Carlos.