Re: [PATCH] nsswitch: Add group merging support

[Stephen Gallagher <sgallagh at redhat dot com>]

On 03/28/2016 01:16 PM, Florian Weimer wrote:
> On 03/28/2016 03:55 PM, Stephen Gallagher wrote:
>> --- a/grp/Versions
>> +++ b/grp/Versions
>> @@ -25,7 +25,8 @@ libc {
>>      getgrent_r; getgrgid_r; getgrnam_r;
>>    }
>>    GLIBC_2.2.4 {
>>      # g*
>>      getgrouplist;
>> +    __merge_grp; __copy_grp;
>>    }
>>  }
> 
> Did this really pass âmake checkâ?  It should have failed the ABI test.
> 
> You need to use GLIBC_PRIVATE.  These functions are not intended to
> become part of the public ABI.
> 
> Thanks,
> Florian
> 

Ugh, that was a mistake, clearly. I didn't run the full `make check` suite
there, I just built and confirmed that it still built and functioned.

Attachment: signature.asc
Description: OpenPGP digital signature