Re: [PATCH] nsswitch: Add group merging support

[Mike Frysinger <vapier at gentoo dot org>]

On 29 Mar 2016 07:07, Florian Weimer wrote:
> On 03/28/2016 09:40 PM, Mike Frysinger wrote:
> > On 28 Mar 2016 09:50, Stephen Gallagher wrote:
> >> On 03/21/2016 08:40 PM, Mike Frysinger wrote:
> >>> On 04 Jan 2016 09:12, Stephen Gallagher wrote:
> >>>> +a match, the behavior is undefined. +      else +	{ +
> >>>> no_more = __nss_next2 (nip, func_name, NULL, &fct.ptr,
> >>>> status, 0); +	}
> >>> 
> >>> could elide the braces
> >> 
> >> I am aware, but my personal preference is to always have braces
> >> even for single-line IF/ELSE blocks (helps avoid merge issues
> >> like the famous Apple GOTO bug).
> 
> GNU style requires omitting the braces.

easy enough :)

> > w/gcc-6 coming down the pike, i'd rather just go with relying on
> > the new warning flag about misleading indentation.
> 
> GCC 6 only warns about misleading additional indentation, not missing
> indentation:

that's what we're talking about here though.  the "Apple GOTO bug" was:
	if (foo)
		goto error;
		goto error;
-mike

Attachment: signature.asc
Description: Digital signature