This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v3] powerpc: Add optimized P8 strspn
- From: "Paul E. Murphy" <murphyp at linux dot vnet dot ibm dot com>
- To: Tulio Magno Quites Machado Filho <tuliom at linux dot vnet dot ibm dot com>, "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>
- Date: Thu, 7 Apr 2016 15:55:03 -0500
- Subject: Re: [PATCH v3] powerpc: Add optimized P8 strspn
- Authentication-results: sourceware.org; auth=none
- References: <5702A88A dot 7060507 at linux dot vnet dot ibm dot com> <87r3eh8dvr dot fsf at totoro dot br dot ibm dot com>
Pushed as 25dba0a with the trivial change pointed out by Tulio.
On 04/07/2016 01:36 PM, Tulio Magno Quites Machado Filho wrote:
> "Paul E. Murphy" <murphyp@linux.vnet.ibm.com> writes:
>
>> diff --git a/sysdeps/powerpc/powerpc64/multiarch/Makefile b/sysdeps/powerpc/powerpc64/multiarch/Makefile
>> index 3b0e3a0..7ed56bf 100644
>> --- a/sysdeps/powerpc/powerpc64/multiarch/Makefile
>> +++ b/sysdeps/powerpc/powerpc64/multiarch/Makefile
>> @@ -19,7 +19,8 @@ sysdep_routines += memcpy-power7 memcpy-a2 memcpy-power6 memcpy-cell \
>> strcmp-power8 strcmp-power7 strcmp-ppc64 \
>> strcat-power8 strcat-power7 strcat-ppc64 \
>> memmove-power7 memmove-ppc64 wordcopy-ppc64 bcopy-ppc64 \
>> - strncpy-power8 strstr-power7 strstr-ppc64
>> + strncpy-power8 strstr-power7 strstr-ppc64 \
>> + strspn-power8 strspn-ppc64
>
> I'm afraid you'll have another conflict here with due to the strlen
> optimization and the strcasestr optimization.
>
>> +/* size_t [r3] strspn (const char *string [r3],
>> + const char *needleAccept [r4] */
>
> Missing ) here ----------------------------------------^
>
> LGTM.
>