This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] getnameinfo: Do not restore errno on error

From: Florian Weimer <fweimer at redhat dot com>
To: "Carlos O'Donell" <carlos at redhat dot com>, Zack Weinberg <zackw at panix dot com>
Cc: GNU C Library <libc-alpha at sourceware dot org>
Date: Thu, 28 Apr 2016 17:50:51 +0200
Subject: Re: [PATCH] getnameinfo: Do not restore errno on error
Authentication-results: sourceware.org; auth=none
References: <56DEE16A dot 5010305 at redhat dot com> <CAKCAbMjp_gRyQqDPiDrj=P0xqSv_wqO7weBPWMCdJnrPh9xt-w at mail dot gmail dot com> <56DEEDCA dot 4030308 at redhat dot com> <CAKCAbMi4OdFL-t0zoLiuPy7Nqjaj9NvrbyBAB42t4kR84YiNCQ at mail dot gmail dot com> <56DF01EE dot 4090401 at redhat dot com> <5722246A dot 5060205 at redhat dot com>

On 04/28/2016 04:55 PM, Carlos O'Donell wrote:

I doubt applications which rely on a preserved errno value exist, and if
they do so, they are not portable, and can even break when tested with
cwrap/nss_wrapper.


I agree with Andreas and Florian.

Thanks, I've pushed the patch. It simplifies future cleanupsâI want tosplit up getnameinfo into separate functions for host and service nameprocessing.


Florian

References:
- Re: [PATCH] getnameinfo: Do not restore errno on error
  - From: Carlos O'Donell

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]