This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Add nextup and nextdown math functions

From: Florian Weimer <fweimer at redhat dot com>
To: Rajalakshmi Srinivasaraghavan <raji at linux dot vnet dot ibm dot com>
Cc: libc-alpha at sourceware dot org
Date: Fri, 20 May 2016 10:31:23 +0200
Subject: Re: [PATCH] Add nextup and nextdown math functions
Authentication-results: sourceware.org; auth=none
References: <1463727477-1909-1-git-send-email-raji at linux dot vnet dot ibm dot com>

On 05/20/2016 08:57 AM, Rajalakshmi Srinivasaraghavan wrote:

+#ifndef FLOAT
+# define FLOAT double
+# define NEXTAFTER nextafter
+# ifdef USE_AS_NEXTDOWN
+#  define NEXTUP nextdown
+# else
+#  define NEXTUP nextup
+# endif
+#endif
+
+#define INTERNAL(X) INTERNAL1(X)
+#define INTERNAL1(X) __##X
+
+FLOAT
+INTERNAL(NEXTUP) (FLOAT x)
+{
+#ifdef USE_AS_NEXTDOWN

Would it make sense to have a file without defaults, and use #ifUSE_AS_NEXTDOWN (instead of #ifdef USE_AS_NEXTDOWN)?

In the past, I think we had bugs because of typos or missing overridesin such constructs, and if the template doesn't have defaults, such bugsare less likely to happen.


Thanks,
Florian

Follow-Ups:
- Re: [PATCH] Add nextup and nextdown math functions
  - From: Joseph Myers

References:
- [PATCH] Add nextup and nextdown math functions
  - From: Rajalakshmi Srinivasaraghavan

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]