This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] libio: use PTR_MANGLE/PTR_DEMANGLE for FILE vtables

From: Mike Frysinger <vapier at gentoo dot org>
To: Kees Cook <keescook at chromium dot org>
Cc: libc-alpha at sourceware dot org, Florian Weimer <fweimer at redhat dot com>, Adam Conrad <adconrad at 0c3 dot net>, Joseph Myers <joseph at codesourcery dot com>, Yunlian Jiang <yunlian at google dot com>
Date: Mon, 23 May 2016 16:34:30 -0400
Subject: Re: [PATCH] libio: use PTR_MANGLE/PTR_DEMANGLE for FILE vtables
Authentication-results: sourceware.org; auth=none
References: <20160523200235 dot GA32189 at www dot outflux dot net>

On 23 May 2016 13:02, Kees Cook wrote:
> --- a/libio/libioP.h
> +++ b/libio/libioP.h
> +static inline void
> +__mangle_vtable(const struct _IO_jump_t **vtable, const struct _IO_jump_t *table)

any reason to not use a name like "_IO_mangle_vtable" ?

GNU style says to put a space before the (

> +{
> +    struct _IO_jump_t *ptr = (struct _IO_jump_t *)table;
> +#ifndef USE_COMPAT_LIBIO
> +    PTR_MANGLE (ptr);
> +#endif
> +    *vtable = ptr;
> +}

GNU style says indent with 2 spaces rather than 4

otherwise, lgtm
-mike

Attachment: signature.asc
Description: Digital signature

Follow-Ups:
- Re: [PATCH] libio: use PTR_MANGLE/PTR_DEMANGLE for FILE vtables
  - From: Kees Cook

References:
- [PATCH] libio: use PTR_MANGLE/PTR_DEMANGLE for FILE vtables
  - From: Kees Cook

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]