This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 1/3] Optimize trunc() and truncf().

From: Mike Frysinger <vapier at gentoo dot org>
To: Joseph Myers <joseph at codesourcery dot com>
Cc: Matt Turner <mattst88 at gmail dot com>, libc-alpha at sourceware dot org
Date: Wed, 25 May 2016 13:20:44 -0400
Subject: Re: [PATCH 1/3] Optimize trunc() and truncf().
Authentication-results: sourceware.org; auth=none
References: <1464139950-31943-1-git-send-email-mattst88 at gmail dot com> <alpine dot DEB dot 2 dot 20 dot 1605251535220 dot 2813 at digraph dot polyomino dot org dot uk>

On 25 May 2016 15:36, Joseph Myers wrote:
> On Tue, 24 May 2016, Matt Turner wrote:
> > -  else
> > -    {
> > -      if (j0 == 0x400)
> > -	/* x is inf or NaN.  */
> > -	return x + x;
> > -    }
> 
> You're removing too much code here.  You need to keep this addition in the 
> NaN case to ensure that signaling NaNs raise "invalid" and get converted 
> to quiet NaNs in the process.

does this mean current test coverage is insufficient ?
-mike

Attachment: signature.asc
Description: Digital signature

Follow-Ups:
- Re: [PATCH 1/3] Optimize trunc() and truncf().
  - From: Joseph Myers

References:
- [PATCH 1/3] Optimize trunc() and truncf().
  - From: Matt Turner
- Re: [PATCH 1/3] Optimize trunc() and truncf().
  - From: Joseph Myers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]