This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] [BZ #19654] Added tests for *_finite aliases from libmvec
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Andrew Senkevich <andrew dot n dot senkevich at gmail dot com>
- Cc: libc-alpha <libc-alpha at sourceware dot org>
- Date: Thu, 9 Jun 2016 16:47:07 +0000
- Subject: Re: [PATCH] [BZ #19654] Added tests for *_finite aliases from libmvec
- Authentication-results: sourceware.org; auth=none
- References: <CAMXFM3uz=Xi0Ogj0MYrCgDque_dtRaXTiX2dX3dSua42-Pgs=Q at mail dot gmail dot com> <alpine dot DEB dot 2 dot 20 dot 1605172302480 dot 6325 at digraph dot polyomino dot org dot uk> <CAMXFM3tFetvBcE3JF5B47_Mm0fOWbBtTu0TxJ=soqMhPD2Qm4w at mail dot gmail dot com>
On Fri, 3 Jun 2016, Andrew Senkevich wrote:
> + return (test_finite_alias ());
Don't use redundant parentheses around return value (the only case they
are appropriate in a return statement is if the value wraps onto multiple
lines and so they ensure correct indentation). This line with this
problem appears twice in the patch.
> +int
> +test_finite_alias (void)
> +{
> + int i;
> +
> + init_arg ();
> +
> + if (arch_check)
> + {
> + return (77);
> + }
Likewise, and avoid redundant {} around single-statement if-body.
> + if (log_res[0] != 0.0) return (1);
> + if (exp_res[0] != 1.0) return (1);
> + if (pow_res[0] != 1.0) return (1);
Again, avoid redundant parentheses.
OK with those changes.
--
Joseph S. Myers
joseph@codesourcery.com