This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2] Fix misaligned access accessing HEADER struct in res_query.c

From: Mike Frysinger <vapier at gentoo dot org>
To: John David Anglin <dave dot anglin at bell dot net>
Cc: GNU C Library <libc-alpha at sourceware dot org>, Carlos O'Donell <carlos at redhat dot com>
Date: Wed, 22 Jun 2016 06:51:17 -0400
Subject: Re: [PATCH v2] Fix misaligned access accessing HEADER struct in res_query.c
Authentication-results: sourceware.org; auth=none
References: <5E7CF115-219A-4260-BE53-19B5A8D1D7F3 at bell dot net> <E69B5C56-452D-4433-83C4-FC234F01194A at bell dot net>

On 17 Jun 2016 18:52, John David Anglin wrote:
> --- a/resolv/res_mkquery.c
> +++ b/resolv/res_mkquery.c
> @@ -83,6 +83,8 @@
>  # define RANDOM_BITS(Var) { uint64_t v64; HP_TIMING_NOW (v64); Var = v64; }
>  #endif
>  
> +typedef HEADER __attribute__ ((aligned(1))) HEADER1;

could do with a comment above it explaining what this is all about

should be __aligned__

bike shed: maybe "UHEADER" is better ?

code-wise, should this file always be using this variant ?  would
it be too ugly to do:
	typedef ...
	#define HEADER HEADER1
-mike

Attachment: signature.asc
Description: Digital signature

Follow-Ups:
- [PATCH v3] Fix misaligned accesses to fields in HEADER struct defined in <arpa/nameser_compat.h>
  - From: John David Anglin

References:
- [PATCH] Fix misaligned access accessing HEADER struct in res_query.c
  - From: John David Anglin
- Re: [PATCH v2] Fix misaligned access accessing HEADER struct in res_query.c
  - From: John David Anglin

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]