This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] nptl: Add more coverage in tst-cancel4

From: Mike Frysinger <vapier at gentoo dot org>
To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
Cc: libc-alpha at sourceware dot org
Date: Mon, 4 Jul 2016 21:13:05 -0400
Subject: Re: [PATCH] nptl: Add more coverage in tst-cancel4
Authentication-results: sourceware.org; auth=none
References: <1465918948-13371-1-git-send-email-adhemerval.zanella@linaro.org> <20160704022744.GS4685@vapier.lan> <577A5586.5090700@linaro.org>

On 04 Jul 2016 09:24, Adhemerval Zanella wrote:
> On 03/07/2016 23:27, Mike Frysinger wrote:
> > On 14 Jun 2016 12:42, Adhemerval Zanella wrote:
> >> +      printf ("%s: cannot generate temp file name\n", __FUNCTION__);
> > 
> > __func__ is the portable name isn't it ?
> > 
> > ignoring that, should this (all the other error messages you've added)
> > end with %m ?
> 
> I am not sure about '__func__', but I think %m seems reasonable. 

__FUNCTION__ is a gcc extension.  the standards added __func__.
-mike

Attachment: signature.asc
Description: Digital signature

References:
- Re: [PATCH] nptl: Add more coverage in tst-cancel4
  - From: Mike Frysinger
- Re: [PATCH] nptl: Add more coverage in tst-cancel4
  - From: Adhemerval Zanella

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]