This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [2.24 PATCH 2/3] Minimize sysdeps code involved in defining major/minor/makedev.
- From: Zack Weinberg <zackw at panix dot com>
- To: "Carlos O'Donell" <carlos at redhat dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>, Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, Mike Frysinger <vapier at gentoo dot org>
- Date: Mon, 1 Aug 2016 17:28:17 -0400
- Subject: Re: [2.24 PATCH 2/3] Minimize sysdeps code involved in defining major/minor/makedev.
- Authentication-results: sourceware.org; auth=none
- References: <cover.1469994984.git.zackw@panix.com> <f8c0d2303f58584f353d8c0dcc484c1ff911c299.1469994984.git.zackw@panix.com> <20d95e83-a254-e8da-60d8-6f02650fa4c2@redhat.com>
On Mon, Aug 1, 2016 at 4:55 PM, Carlos O'Donell <carlos@redhat.com> wrote:
> (3) New symbols?
>
> Overall this looks good. I have only questions about why the new functions
> are going into the users namespace. Traditionally we put things into the
> implementation namespace, particularly to discourage users calling the
> functions directly. I would like the user to use the normal interfaces for
> calling this functionality.
I would agree if these were truly new functions, but they're not. They
already exist, with the user-namespace names, in every Linux-based
port. `grep gnu_dev_ $(find sysdeps -name libc*.abilist)` and see for
yourself.