This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2 1/2] count number of loaded objects in each namespace only once

From: Mike Frysinger <vapier at gentoo dot org>
To: Gleb Natapov <gleb at scylladb dot com>
Cc: libc-alpha at sourceware dot org
Date: Thu, 4 Aug 2016 23:31:14 -0400
Subject: Re: [PATCH v2 1/2] count number of loaded objects in each namespace only once
Authentication-results: sourceware.org; auth=none
References: <1470232359-18696-1-git-send-email-gleb@scylladb.com> <1470232359-18696-2-git-send-email-gleb@scylladb.com>

On 03 Aug 2016 16:52, Gleb Natapov wrote:
> --- a/elf/dl-iteratephdr.c
> +++ b/elf/dl-iteratephdr.c
> @@ -48,17 +48,18 @@ __dl_iterate_phdr (int (*callback) (struct dl_phdr_info *info,
>  #ifdef SHARED
>    const void *caller = RETURN_ADDRESS (0);
>    for (Lmid_t cnt = GL(dl_nns) - 1; cnt > 0; --cnt)
> +    {
> +    /* We have to count the total number of loaded objects.  */
> +    nloaded += GL(dl_ns)[cnt]._ns_nloaded;
>      for (struct link_map *l = GL(dl_ns)[cnt]._ns_loaded; l; l = l->l_next)

since you've added a scope here, all the code in it needs to be indented
by one more level
-mike

Attachment: signature.asc
Description: Digital signature

References:
- [PATCH v2 0/2] count number of loaded objects in each namespace only once
  - From: Gleb Natapov
- [PATCH v2 1/2] count number of loaded objects in each namespace only once
  - From: Gleb Natapov

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]