This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCHv2 03/11] Support for type-generic libm function implementations libm


On Wed, 10 Aug 2016, Paul E. Murphy wrote:

> Ok, here is a patch which does all of the above.  I like this approach
> much better than the previous patches.  This approach is much more
> inline with the existing idioms, much easier to understand, and more
> robust.

The shell code you're embedding in the makefile uses $${gfunc/F/} which is 
a bash-specific feature.  Makefile shell code is run with /bin/sh; you can 
only rely on POSIX shell features.  dash does not support this non-POSIX 
feature.

> Notable changes from the last patch:

This patch has not addressed my point that the comment about LDBL_EPSILON 
for IBM long double should refer to both underflows and overflows.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]