This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] argp: Do not override GCC keywords with macros [BZ #16907]

From: Paul Eggert <eggert at cs dot ucla dot edu>
To: Florian Weimer <fweimer at redhat dot com>, libc-alpha at sourceware dot org
Date: Sun, 14 Aug 2016 19:18:45 -0700
Subject: Re: [PATCH] argp: Do not override GCC keywords with macros [BZ #16907]
Authentication-results: sourceware.org; auth=none
References: <20160814190124.C1152403B91DC@oldenburg.str.redhat.com>

Florian Weimer wrote:

This commit does not sync with gnulib because gnulib has started to use
_GL_* macros in the header file, which are arguably in the gnulib
implementation space and not suitable for an installed glibc header
file.

I'd rather keep the files in sync if possible. How about if we rename theaffected macro from _GL_ATTRIBUTE_FORMAT to __attribute_format__ (or whateverother name you like that is in the glibc space? That way, Gnulib can stay insync better.

Similarly, the files shared with Gnulib can define __BEGIN_DECLS and __END_DECLSwhen __BEGIN_DECL is not already defined.

Follow-Ups:
- Re: [PATCH] argp: Do not override GCC keywords with macros [BZ #16907]
  - From: Florian Weimer

References:
- [PATCH] argp: Do not override GCC keywords with macros [BZ #16907]
  - From: Florian Weimer

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]