Re: [PATCH] locale: fix hard-coded reference to gcc -E

[Mike Frysinger <vapier at gentoo dot org>]

On 24 Aug 2016 09:57, Jérémy Rosen wrote:
> When new version of compilers are published, they may not be compatible with 
> older versions of software. This is particularly common when software is built
> with -Werror.
> 
> Autotools provides a way for a user to specify the name of his compiler using a
> set of variables ($CC $CXX $CPP etc.). Those variables are used correctly when
> compiling glibc but the script used to generate transliterations in the locale/
> subdirectory directly calls the gcc binary to get the output of the 
> preprocessor instead of using the $CPP variable provided by the build 
> environment. 
> 
> This patch replaces the hard-coded reference to the gcc binary with the proper
> environment variable, thus allowing a user to override it.
> 
> 
> ---
>  locale/gen-translit.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/locale/gen-translit.pl b/locale/gen-translit.pl
> index 30d3f2f..7b287fa 100644
> --- a/locale/gen-translit.pl
> +++ b/locale/gen-translit.pl
> @@ -1,5 +1,5 @@
>  #!/usr/bin/perl -w
> -open F, "cat C-translit.h.in | gcc -E - |" || die "Cannot preprocess input file";
> +open F, 'cat C-translit.h.in | ${CPP:-gcc -E} - |' || die "Cannot preprocess input file";

should this go even further with:
  ${CPP:-${CC} -E}
-mike

Attachment: signature.asc
Description: Digital signature