Re: [COMMITTED] Fix test-skeleton C99 designed initialization

[Florian Weimer <fweimer at redhat dot com>]

On 08/26/2016 10:58 PM, Adhemerval Zanella wrote:
> ISO C forbids empty initializer braces (6.7.9 initializer-list must
> contain at least one initializer). However GCC allows it, generating
> a warning depending of the version.
>
> With GCC 4.8 on ARM I noticed tst-initializers1.c fails to build with:
>
> In file included from tst-initializers1.c:60:0:
> ../test-skeleton.c: In function 'delayed_exit_thread':
> ../test-skeleton.c:687:10: error: missing initializer for field 'tv_sec' of 'struct timespec' [-Werror=missing-field-initializers]
>    struct timespec remaining = {}

Thanks for fixing this.

The root cause is that we compile tst-initializers1 with -Wall -W 
-Werror (presumably to catch initializer issues in <pthread.h>).  If we 
keep expanding test-skeleton.c, this will make it quite difficult to 
keep supporting many different compilers.  I guess this is another 
reason to switch to something like libtest, with separate compilation of 
these test helpers.

Florian