This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Fix rpcgen buffer overrun (bug 20790)

From: Florian Weimer <fweimer at redhat dot com>
To: Joseph Myers <joseph at codesourcery dot com>
Cc: libc-alpha at sourceware dot org
Date: Tue, 8 Nov 2016 09:37:17 +0100
Subject: Re: Fix rpcgen buffer overrun (bug 20790)
Authentication-results: sourceware.org; auth=none
References: <alpine.DEB.2.20.1611071839320.3948@digraph.polyomino.org.uk>

On 11/07/2016 07:40 PM, Joseph Myers wrote:

2016-11-07  Joseph Myers  <joseph@codesourcery.com>

	[BZ #20790]
	* sunrpc/rpc_parse.c (get_prog_declaration): Increase buffer size
	to MAXLINESIZE.
	* sunrpc/bug20790.x: New file.
	* sunrpc/Makefile [$(run-built-tests) = yes] (rpcgen-tests): New
	variable.
	[$(run-built-tests) = yes] (tests-special): Add $(rpcgen-tests).
	[$(run-built-tests) = yes] ($(rpcgen-tests)): New rule.

This looks okay to me, all things considering. (Fixed-length buffersare against GNU coding standards, but sunrpc/* doesn't really followthem anyway.)


Thanks,
Florian

References:
- Fix rpcgen buffer overrun (bug 20790)
  - From: Joseph Myers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]