This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] m68k: restore handling of R_68K_NONE in elf_machine_lazy_rel()

From: Sergei Trofimovich <slyich at gmail dot com>
To: Andreas Schwab <schwab at linux-m68k dot org>
Cc: libc-alpha at sourceware dot org, Sergei Trofimovich <siarheit at google dot com>, Roland McGrath <roland at hack dot frob dot com>
Date: Tue, 8 Nov 2016 23:56:30 +0000
Subject: Re: [PATCH] m68k: restore handling of R_68K_NONE in elf_machine_lazy_rel()
Authentication-results: sourceware.org; auth=none
References: <20161029134801.15082-1-slyich@gmail.com> <87pomjnp3v.fsf@linux-m68k.org> <20161029171527.423b573e@sf> <87lgx7nkr2.fsf@linux-m68k.org> <20161030101318.6971a5f5@sf> <87shrem71g.fsf@linux-m68k.org>

On Sun, 30 Oct 2016 12:04:59 +0100
Andreas Schwab <schwab@linux-m68k.org> wrote:

> On Okt 30 2016, Sergei Trofimovich <slyich@gmail.com> wrote:
> 
> > Is there a reason to allow R_68K_NONE for non-lazy relocations
> > in elf_machine_rela()
> >
> > +    case R_68K_NONE:           /* Alright, Wilbur.  */
> > +      break;
> >
> > but forbid R_68K_NONE for lazy relocations
> > in elf_machine_lazy_rel()  
> 
> Because the latter must never happen.  Please file a binutils bug with a
> self-contained test case.

Finally extracted one. Filed as:
    https://sourceware.org/bugzilla/show_bug.cgi?id=20796

It is triggered by a mix of -Wl,--gc-sections, -u buggy_symbol
and a shared library where 'buggy_symbol' comes from.

And while at it filed minor bug about R_68K_NONE relocations
to be present in final binaries:
    https://sourceware.org/bugzilla/show_bug.cgi?id=20797

-- 

  Sergei

Attachment: pgpCfxSpLHEUK.pgp
Description: Цифровая подпись OpenPGP

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]