Re: [PATCH] Always suppress libc-internal declarations for C++ code.

[Mike Frysinger <vapier at gentoo dot org>]

On 27 Nov 2016 12:37, Zack Weinberg wrote:
> On Sun, Nov 27, 2016 at 1:50 AM, Mike Frysinger <vapier@gentoo.org> wrote:
> > On 21 Nov 2016 12:42, Zack Weinberg wrote:
> >> This flushed out some minor problems: test-skeleton.c uses uintptr_t
> >> but wasn't including <stdint.h>
> >
> > seems like this should be installed as obvious by itself
> 
> Done (patch appended)
> 
> >> libio.h tested _GNU_SOURCE instead of __USE_GNU in one place.
> >
> > makes sense regardless too
> 
> Also done

these two patches look fine

> > a quick grep shows fnmatch.h has a similar error
> 
> Isn't fnmatch.h shared with gnulib?  I don't feel like I understand
> the constraints on code shared with gnulib, certainly not enough to
> call it "obvious."  Also, some of the conditionals in there don't make
> sense to me ("#if !defined _POSIX_C_SOURCE || _POSIX_C_SOURCE < 2 ||
> defined _GNU_SOURCE" -- what's that even supposed to do?)

i've sent a sep patch for that so we can discuss it there ;)
-mike

Attachment: signature.asc
Description: Digital signature