This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: rename consolidation question
- From: Steve Ellcey <sellcey at caviumnetworks dot com>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, "Norov, Yuri" <Yuri dot Norov at caviumnetworks dot com>
- Cc: "Pinski, Andrew" <Andrew dot Pinski at cavium dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Tue, 13 Dec 2016 10:59:14 -0800
- Subject: Re: rename consolidation question
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Steve dot Ellcey at cavium dot com;
- References: <SN2PR0701MB10718E2E3CEC567403A6B535F59B0@SN2PR0701MB1071.namprd07.prod.outlook.com> <7b461d8b-8998-58cc-e5fe-d50b3c960d8b@linaro.org>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On Tue, 2016-12-13 at 16:53 -0200, Adhemerval Zanella wrote:
>
> On 13/12/2016 16:22, Ellcey, Steve wrote:
> >
> > Yury and Adhemerval,
> >
> > I was wondering about the status of the rename consolidation patch
> > is. I found this string:
> >
> > https://sourceware.org/ml/libc-alpha/2016-10/msg00247.html
> >
> > But I am not sure what the resolution is and what patch we want.
> > I have been doing the wrong thing in my builds so far by defining
> > __ARCH_WANT_RENAMEAT in the ILP32 aarch64 build but I should not
> > be doing that. If I remove that define then the build fails when
> > compiling rename.c. I see that yury's branch removes
> > sysdeps/unix/sysv/linux/generic/rename.c and adds
> > sysdeps/unix/sysv/linux/rename.c and
> > sysdeps/unix/sysv/linux/renameat.c.
> > It also removed renameat from
> > sysdeps/unix/sysv/linux/syscalls.list.
> >
> > Is that the patch we need to send to libc-alpha?
> >
> > Steve Ellcey
> I think it would require two simple patches:
>
> - one to consolidate rename to use either __SYS_rename,
> __SYS_renameat,
> or __SYS_renameat2;
> - and another one to consolidate renameat to user either
> __SYS_rename
> or __SYS_renameat2.
>
> I added a scratch branch for both in my local repo [1]. I will sent
> them upstream and try to get them for next release.
>
> [1] https://github.com/zatrazz/glibc/tree/master-rename
When you say the next release do you mean the one being worked on now
(2.25) or the one after that? We need some type of rename patch to
support ILP32 on aarch64 and I am still hoping to get support for ILP32
checked in for 2.25.
Steve Ellcey