This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/4] Add framework for tunables
- From: Andreas Schwab <schwab at linux-m68k dot org>
- To: Siddhesh Poyarekar <siddhesh at sourceware dot org>
- Cc: libc-alpha at sourceware dot org, fweimer at redhat dot com, carlos at redhat dot com
- Date: Mon, 06 Feb 2017 23:59:09 +0100
- Subject: Re: [PATCH 1/4] Add framework for tunables
- Authentication-results: sourceware.org; auth=none
- References: <1483070938-2308-1-git-send-email-siddhesh@sourceware.org> <1483070938-2308-2-git-send-email-siddhesh@sourceware.org>
On Dez 30 2016, Siddhesh Poyarekar <siddhesh@sourceware.org> wrote:
> +/* Set the tunable value. This is called by the module that the tunable exists
> + in. */
> +void
> +__tunable_set_val (tunable_id_t id, void *valp, tunable_callback_t callback)
> +{
> + tunable_t *cur = &tunable_list[id];
> +
> + /* Don't do anything if our tunable was not set during initialization or if
> + it failed validation. */
> + if (cur->strval == NULL)
> + return;
> +
> + if (valp == NULL)
> + goto cb;
Why goto?
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."