Re: [PATCH 1/4] Add framework for tunables

[Siddhesh Poyarekar <siddhesh at sourceware dot org>]

On Tuesday 07 February 2017 04:06 AM, Andreas Schwab wrote:
> On Dez 30 2016, Siddhesh Poyarekar <siddhesh@sourceware.org> wrote:
> 
>> diff --git a/malloc/arena.c b/malloc/arena.c
>> index eed4247..234035f 100644
>> --- a/malloc/arena.c
>> +++ b/malloc/arena.c
>> @@ -19,6 +19,11 @@
>>  
>>  #include <stdbool.h>
>>  
>> +#if HAVE_TUNABLES
>> +# define TUNABLE_NAMESPACE malloc
>> +#endif
>> +#include <elf/dl-tunables.h>
>> +
>>  /* Compile-time constants.  */
>>  
>>  #define HEAP_MIN_SIZE (32 * 1024)
>> @@ -204,6 +209,34 @@ __malloc_fork_unlock_child (void)
>>    __libc_lock_init (list_lock);
>>  }
>>  
>> +#if HAVE_TUNABLES
>> +static inline int do_set_mallopt_check (int32_t value);
>> +void
>> +DL_TUNABLE_CALLBACK (set_mallopt_check) (void *valp)
>> +{
>> +  int32_t value = *(int32_t *) valp;
> 
> This is wrong.  The callback receives a pointer to tunable_val_t.

Does the attached (sanity tested on little-endian) patch work for you?

Siddhesh

Attachment: patch
Description: Text document