This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2][AArch64] Add more cfi annotations to tlsdesc entry points
- From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- To: libc-alpha at sourceware dot org
- Date: Tue, 7 Feb 2017 18:26:35 -0200
- Subject: Re: [PATCH v2][AArch64] Add more cfi annotations to tlsdesc entry points
- Authentication-results: sourceware.org; auth=none
- References: <584AB057.5050605@arm.com> <39560805-b142-5681-4f39-096bf7045e2a@twiddle.net> <584FEAE9.10207@arm.com> <586FBE78.8020901@arm.com> <5885E98C.7060608@arm.com>
On 23/01/2017 09:31, Szabolcs Nagy wrote:
> On 06/01/17 15:57, Szabolcs Nagy wrote:
>> On 13/12/16 12:34, Szabolcs Nagy wrote:
>>> Backtrace through _dl_tlsdesc_resolve_rela was broken because the offset
>>> of x30 from cfa was not in the debug info.
>>>
>>> Add enough annotation so backtracing from the dynamic linker through
>>> tlsdesc entry points works and the debugger shows registers correctly.
>>>
>>> v2:
>>> - group cfi_rel_offset annotations for smaller debug info.
>>>
>>> 2016-12-13 Szabolcs Nagy <szabolcs.nagy@arm.com>
>>>
>>> * sysdeps/aarch64/dl-tlsdesc.S (_dl_tlsdesc_dynamic): Add cfi
>>> annotation.
>>> (_dl_tlsdesc_resolve_rela, _dl_tlsdesc_resolve_hold): Likewise.
>>>
>>
>> ping.
>>
>
> ping.
>
> this is a bug fix which should go in 2.25 i think.
> (e.g. the elf/tst-tls-manydynamic crash is hard to debug without this).
>
Sorry if I did catch this up for 2.25, LGTM. I think it is worth to at
least backport to 2.25 branch.