This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/4] Consolidate Linux accept implementation
- From: Phil Blundell <pb at pbcl dot net>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, libc-alpha at sourceware dot org
- Date: Wed, 08 Feb 2017 20:59:40 +0000
- Subject: Re: [PATCH 1/4] Consolidate Linux accept implementation
- Authentication-results: sourceware.org; auth=none
- References: <1485784926-2172-1-git-send-email-adhemerval.zanella@linaro.org> <1485784926-2172-2-git-send-email-adhemerval.zanella@linaro.org>
On Mon, 2017-01-30 at 12:02 -0200, Adhemerval Zanella wrote:
>
> 2. Define __NR_acccept as default (__ASSUME_ACCEPT_SYSCALL) and
> undef for
Too many "c"s in accept?
> diff --git a/sysdeps/unix/sysv/linux/m68k/kernel-features.h
> b/sysdeps/unix/sysv/linux/m68k/kernel-features.h
> index 6811a28..f583ae7 100644
> --- a/sysdeps/unix/sysv/linux/m68k/kernel-features.h
> +++ b/sysdeps/unix/sysv/linux/m68k/kernel-features.h
> @@ -27,7 +27,6 @@
> # define __ASSUME_BIND_SYSCALL 1
> # define __ASSUME_CONNECT_SYSCALL 1
> # define __ASSUME_LISTEN_SYSCALL 1
> -# define __ASSUME_ACCEPT4_FOR_ACCEPT_SYSCALL 1
> # define __ASSUME_GETSOCKOPT_SYSCALL 1
> # define __ASSUME_SETSOCKOPT_SYSCALL 1
> # define __ASSUME_GETSOCKNAME_SYSCALL 1
> @@ -41,7 +40,10 @@
>
> #include_next <kernel-features.h>
>
> +#undef __ASSUME_ACCEPT_SYSCALL
> +
> #if __LINUX_KERNEL_VERSION < 0x040300
> +# undef __ASSUME_ACCCEPT_SYSCALL
This is a bit odd. __ASSUME_ACCCEPT_SYSCALL never seems to be defined
anywhere that I can find, but you are explicitly undefining it for
these old kernels. I would have assumed it was a typo for
__ASSUME_ACCEPT_SYSCALL if you weren't also undefining that one a
couple of lines further up. Can you clarify?
p.