This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Add new templates for IEEE wrappers
- From: Joseph Myers <joseph at codesourcery dot com>
- To: "Gabriel F. T. Gomes" <gftg at linux dot vnet dot ibm dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Mon, 20 Feb 2017 23:14:29 +0000
- Subject: Re: [PATCH] Add new templates for IEEE wrappers
- Authentication-results: sourceware.org; auth=none
- References: <1487348516-18343-1-git-send-email-gftg@linux.vnet.ibm.com>
On Fri, 17 Feb 2017, Gabriel F. T. Gomes wrote:
> +#if defined __USE_WRAPPER_TEMPLATE && __USE_WRAPPER_TEMPLATE
I think throughout you should just use "#if __USE_WRAPPER_TEMPLATE", so
that not being defined is an error.
> diff --git a/math/w_lgamma_r_template.c b/math/w_lgamma_r_template.c
> + if (__glibc_unlikely (!isfinite (y)) && isfinite (x))
> + /* Overflow. */
Or pole error for negative integer arguments (inaccurate comment).
> diff --git a/math/w_lgamma_template.c b/math/w_lgamma_template.c
> + if (__glibc_unlikely (!isfinite (y)) && isfinite (x))
> + /* Overflow. */
Likewise.
> + else if (M_SUF (__floor) (x) == x && x < 0)
> + /* Domain error: tgamma(x<0). */
*integer* x < 0, not any x < 0 (inaccurate comment).
OK with those changes.
--
Joseph S. Myers
joseph@codesourcery.com