This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 3/4] Miscellaneous 'safe' testsuite changes.
- From: Andreas Schwab <schwab at linux-m68k dot org>
- To: Zack Weinberg <zackw at panix dot com>
- Cc: Florian Weimer <fw at deneb dot enyo dot de>, "Carlos O'Donell" <carlos at redhat dot com>, GNU C Library <libc-alpha at sourceware dot org>, Joseph Myers <joseph at codesourcery dot com>, Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- Date: Thu, 02 Mar 2017 14:56:56 +0100
- Subject: Re: [PATCH 3/4] Miscellaneous 'safe' testsuite changes.
- Authentication-results: sourceware.org; auth=none
- References: <20170220130342.6373-1-zackw@panix.com> <20170220130342.6373-2-zackw@panix.com> <20170220130342.6373-3-zackw@panix.com> <20170220130342.6373-4-zackw@panix.com> <8c498c93-b2cf-a2af-a741-bc721ac47f6e@redhat.com> <f37b8c3f-5994-102f-219a-8a4dffafbd16@panix.com> <87k28eugjp.fsf@mid.deneb.enyo.de> <CAKCAbMgjBQwhebioj4my9kQ4zVkwnzDupzhV79gzPBnZ4ha0Aw@mail.gmail.com>
On Feb 26 2017, Zack Weinberg <zackw@panix.com> wrote:
> diff --git a/elf/get-dynamic-info.h b/elf/get-dynamic-info.h
> index 86760d8844..6413558975 100644
> --- a/elf/get-dynamic-info.h
> +++ b/elf/get-dynamic-info.h
> @@ -16,8 +16,11 @@
> License along with the GNU C Library; if not, see
> <http://www.gnu.org/licenses/>. */
>
> +#ifndef _GET_DYNAMIC_INFO_H
> +#define _GET_DYNAMIC_INFO_H 1
> +
> #include <assert.h>
> -#include <libc-internal.h>
> +#include <libc-diag.h>
>
> #ifndef RESOLVE_MAP
> static
> @@ -179,3 +182,5 @@ elf_get_dynamic_info (struct link_map *l, ElfW(Dyn) *temp)
> info[DT_RPATH] = NULL;
> #endif
> }
> +
> +#endif /* get-dynamic-info.h */
This is bogus. The file must be included multiple times, depending on
the definition of RESOLVE_MAP.
This breaks powerpc
<https://build.opensuse.org/package/live_build_log/home:Andreas_Schwab:glibc/glibc/p/ppc>.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."