This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Split helper classification macros from mathcalls.h
- From: Joseph Myers <joseph at codesourcery dot com>
- To: "Gabriel F. T. Gomes" <gftg at linux dot vnet dot ibm dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Wed, 8 Mar 2017 20:24:29 +0000
- Subject: Re: [PATCH] Split helper classification macros from mathcalls.h
- Authentication-results: sourceware.org; auth=none
- References: <1488991520-21088-1-git-send-email-gftg@linux.vnet.ibm.com>
On Wed, 8 Mar 2017, Gabriel F. T. Gomes wrote:
> In https://sourceware.org/ml/libc-alpha/2016-11/msg00366.html, Joseph
> suggested that mathcalls.h could need to be split, in order to allow
> the declaration of helper functions (e.g. __signbitf128) when not
> declaring functions protected by a __GLIBC_USE conditional for
> TS-18661-3 (e.g. sinf128). This patch does the split in preparation
> for the float128 work.
__issignaling and __iseqsig have the same requirements for being declared
for all types even when other *f128 functions aren't declared, so that the
type-generic macros work correctly.
> +#if defined __USE_XOPEN_EXTENDED || defined __USE_ISOC99
> +__BEGIN_NAMESPACE_C99
> +#endif
It would make sense to check with libstdc++ maintainers whether the
namespace code is actually needed for these __* functions; it may well not
be. (Conditioning the function declarations on the feature test macros
used for the relevant type-generic macros is unnecessary, but harmless.)
--
Joseph S. Myers
joseph@codesourcery.com