This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Use append attribution to CFLAGS in wcsmbs

From: Mike Frysinger <vapier at gentoo dot org>
To: "Gabriel F. T. Gomes" <gftg at linux dot vnet dot ibm dot com>
Cc: libc-alpha at sourceware dot org
Date: Sat, 11 Mar 2017 21:04:17 -0500
Subject: Re: [PATCH] Use append attribution to CFLAGS in wcsmbs
Authentication-results: sourceware.org; auth=none
References: <1488991673-21932-1-git-send-email-gftg@linux.vnet.ibm.com>

On 08 Mar 2017 13:47, Gabriel F. T. Gomes wrote:
> CFLAGS for several files in wcsmbs/Makefile are set without the append
> operator ("+="), thus ignoring other attributions.  This patch changes
> that so Makefiles in sysdeps can set extra compilation flags.  This is
> being done in preparation for future float128 patches.

i'm not against this, but it seems like we should be doing this
everywhere ?  when i grep for CFLAGS-xxx.c, there's about 650
using = and 250 using +=.

even in this file, you've only changed one block ... there's
more entries in it still using =.
-mike

Attachment: signature.asc
Description: Digital signature

Follow-Ups:
- Re: [PATCH] Use append attribution to CFLAGS in wcsmbs
  - From: Joseph Myers

References:
- [PATCH] Use append attribution to CFLAGS in wcsmbs
  - From: Gabriel F. T. Gomes

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]