This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Disable rest of sunrpc, too [V3]


On 02/27/2017 10:41 AM, Thorsten Kukuk wrote:

Hi,

On Fri, Feb 24, Carlos O'Donell wrote:

On 02/24/2017 09:20 AM, Thorsten Kukuk wrote:
0001-If-sunrpc-code-is-disabled-no-RPC-header-files-rpcge.patch

- Have you run this through SUSE Tumbleweed to see if anything fails to build?

That's part of a SUSE Tumbleweed project, yes. Nothing is using rpcsvc,
neither the header files nor the static library (everything else would
have surprised me).
One package is using rpcgen, a new buildrequires was necessary. That's
all.
Of course only if you run it in a project already converted from sunrpc
to libtirpc.

- Could you also write up something for the distribution maintainers regarding
  any packaging changes this might cause? Text mentioning which headers are now
  going to _not_ be installed would be great, and how they might fix that if
  possible e.g. install X or port to Y.

I really doubt that package maintainers will see any affect of this.
I haven't seen anything except one package out of 3000 calling rpcgen.
I think the rpcsvc code is dead code since day one.

+* rpcgen, librpcsvc and related headers will now only be built and
+  installed when glibc is configured with --enable-obsolete-rpc.
+  Alternative sources can be found at
+  https://github.com/thkukuk/rpcsvc-proto.

I'm going to suggest the following text:

* The rpcgen, librpcsvc and related headers will only be built and
  installed when glibc is configured with --enable-obsolete-rpc.
  This allows alternative RPC implementations, like TIRPC, to be used
  by default. Applications needing features missing from TIRPC should
  consider the rpcsvc-proto project developed by Thorsten Kukuk (SUSE).

OK with that?

Fine with me.

  Thorsten


Hi Thorsten,

I get a testsuite fail:
FAIL: sunrpc/bug20790

This is a "rpcgen-test". As rpcgen isn't available anymore, the test fails:
<build>/sunrpc/rpcgen -c bug20790.x -o <build>/sunrpc/bug20790.out

Can you disable those tests if rpcgen isn't built?

Bye
Stefan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]