This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2] Add page tests to string/test-strnlen.

From: Mike Frysinger <vapier at gentoo dot org>
To: Wainer dos Santos Moschetta <wainersm at linux dot vnet dot ibm dot com>
Cc: libc-alpha at sourceware dot org, dj at redhat dot com
Date: Thu, 16 Mar 2017 22:59:37 -0400
Subject: Re: [PATCH v2] Add page tests to string/test-strnlen.
Authentication-results: sourceware.org; auth=none
References: <20170315180012.6170-1-wainersm@linux.vnet.ibm.com>

On 15 Mar 2017 15:00, Wainer dos Santos Moschetta wrote:
> +  for (i = 0; i < last_offset; i++)
> +    s[i] = 65;

memset ?

> +      FOR_EACH_IMPL (impl, 0)
> +          /* Checks only for maxlen larger than length because other cases are
> +             already covered in do_random_tests.  */
> +          do_one_test (impl, (CHAR *) (s + offset), page_size, exp_len);

incorrect indent.  but please use braces as it'll be less confusing
(especially with that comment in there).
-mike

Attachment: signature.asc
Description: Digital signature

References:
- [PATCH v2] Add page tests to string/test-strnlen.
  - From: Wainer dos Santos Moschetta

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]