This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] posix_spawn: use a larger min stack for -fstack-check [BZ #21253]

On Fri, Mar 17, 2017 at 09:19:24PM +0100, Andreas Schwab wrote:
> On Mär 17 2017, Mike Frysinger <vapier@gentoo.org> wrote:
> 
> > On 17 Mar 2017 12:09, Mike Frysinger wrote:
> >> -  size_t stack_size = ALIGN_UP (argv_size, GLRO(dl_pagesize));
> >> +  size_t stack_size = ALIGN_UP (argv_size, GLRO (dl_pagesize));
> >
> > guess the diff can be a little confusing -- i just fixed spacing here.
> 
> The spacing wasn't wrong.


$ git grep 'GLRO (' [^C]* | wc -l
30
$ git grep 'GLRO(' [^C]* | wc -l
524


The tradition is obviously in favour of the latter variant, but why?




-- 
ldv

Attachment: pgpu285q7Fh5r.pgp
Description: PGP signature

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]