Re: [PATCH v2] posix_spawn: use a larger min stack for -fstack-check [BZ #21253]

[Carlos O'Donell <carlos at redhat dot com>]

On 03/22/2017 02:12 PM, Mike Frysinger wrote:
> On 22 Mar 2017 12:16, Carlos O'Donell wrote:
>> On 03/22/2017 02:05 AM, Mike Frysinger wrote:
>>> On 20 Mar 2017 16:43, Joseph Myers wrote:
>>>> On Mon, 20 Mar 2017, Szabolcs Nagy wrote:
>>>>> in glibc it seems the rule was that there
>>>>> is space in function calls but not necessarily
>>>>> in macro invocation.
>>>>
>>>> Only certain macros that use concatenation to construct a variable name 
>>>> (GLRO), type name (ElfW) etc. - where the result is conceptually a single 
>>>> identifier.  Macros used more like function calls should have the space.  
>>>> That includes ones such as PSEUDO, END, weak_alias, hidden_def etc.
>>>
>>> do we want to formalize it ?
>>> https://sourceware.org/glibc/wiki/Style_and_Conventions#Symbols_and_Parenthesis
>>>
>>> macros that aren't "functions" should omit the space ?
>>> defined() counts as a function right ?
>>
>> Yes, we should formalize it. Please adjust the wiki. We can
>> always clarify further as time goes on or experience shows
>> otherwise.
>>
>> Yes, non-function macros should omit the space, and defined()
>> in my book counts as a function.
> 
> done.  i provided a number of examples to hopefully guide.
> -mike
 
Looks awesome. Thanks for those.

-- 
Cheers,
Carlos.