This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] hppa: Use generic pthread conditional variable support
- From: Aaro Koskinen <aaro dot koskinen at iki dot fi>
- To: John David Anglin <dave dot anglin at bell dot net>
- Cc: GNU C Library <libc-alpha at sourceware dot org>, Carlos O'Donell <carlos at redhat dot com>, Mike Frysinger <vapier at gentoo dot org>, Helge Deller <deller at gmx dot de>
- Date: Sat, 1 Apr 2017 00:21:05 +0300
- Subject: Re: [PATCH] hppa: Use generic pthread conditional variable support
- Authentication-results: sourceware.org; auth=none
- References: <3278DDA9-61C9-44E2-9130-F625953652FA@bell.net>
Hi,
On Sun, Mar 12, 2017 at 10:58:46AM -0400, John David Anglin wrote:
> The attach change switches the hppa target to use the generic pthread
> conditional variable support. We lose compatibility with linuxthreads
> but I don't think that is relevant anymore for the existing distributions.
>
> The change fixes bug nptl/21016.
>
> Okay?
[...]
> 2017-03-12 John David Anglin <danglin@gcc.gnu.org>
>
> [BZ #21016]
> * sysdeps/hppa/nptl/bits/pthreadtypes.h: Use generic data structure
> for conditional variables.
> * sysdeps/unix/sysv/linux/hppa/internaltypes.h (cond_compat_clear):
> Remove.
> (cond_compat_check_and_clear): Likewise.
> * sysdeps/unix/sysv/linux/hppa/pthread.h (PTHREAD_COND_INITIALIZER):
> Revise.
> * sysdeps/unix/sysv/linux/hppa/pthread_cond_broadcast.c: Delete file.
> * sysdeps/unix/sysv/linux/hppa/pthread_cond_destroy.c: Likewise.
> * sysdeps/unix/sysv/linux/hppa/pthread_cond_signal.c: Likewise.
> * sysdeps/unix/sysv/linux/hppa/pthread_cond_wait.c: Likewise.
Should you delete sysdeps/unix/sysv/linux/hppa/pthread_cond_init.c
as well? That code is calling cond_compat_clear() which is removed by
your changes, and the linking fails.
A.