This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Ping^2 Re: Fix bits/socket.h IOC* namespace issues (bug 21267)
- From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- To: libc-alpha at sourceware dot org
- Date: Thu, 6 Apr 2017 16:01:03 -0300
- Subject: Re: Ping^2 Re: Fix bits/socket.h IOC* namespace issues (bug 21267)
- Authentication-results: sourceware.org; auth=none
- References: <alpine.DEB.2.20.1703180031310.9823@digraph.polyomino.org.uk> <alpine.DEB.2.20.1703231758480.21959@digraph.polyomino.org.uk> <alpine.DEB.2.20.1704051556140.13912@digraph.polyomino.org.uk>
On 05/04/2017 12:56, Joseph Myers wrote:
> Ping^2. This patch
> <https://sourceware.org/ml/libc-alpha/2017-03/msg00400.html> is still
> pending review.
>
The patch itself looks good. However, I think the __SYS_SOCKET_H_undef*
macro usage is convoluted and complex, couldn't we just copy the kernel
definition from asm/socket.h and avoid include it on bits/socket.h?