This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[PATCH] Fix stack memory protection on targets where the stack grows upward

From: John David Anglin <dave dot anglin at bell dot net>
To: GNU C Library <libc-alpha at sourceware dot org>
Cc: Carlos O'Donell <carlos at redhat dot com>, Mike Frysinger <vapier at gentoo dot org>, Aurelien Jarno <aurelien at aurel32 dot net>, Helge Deller <deller at gmx dot de>
Date: Sun, 16 Apr 2017 13:20:32 -0400
Subject: [PATCH] Fix stack memory protection on targets where the stack grows upward
Authentication-results: sourceware.org; auth=none

The tst-cputimer1 test fails on hppa.  Using strace to look at the system calls generated by the test,
I observed that there is a mprotect call that passes a non page-aligned addr argument and it fails
with the error EINVAL.

The attached change aligns the old and new guard addresses to page boundaries and fixes the
failing mprotect call.

A version of this patch, hppa/local-stack-grows-up.diff, has been installed in Debian for a long time.
However, the old and new guard values were reversed in the compare.  As a result, the mprotect call
was skipped.  This versions checks that the new_guard value is greater than the old_guard value.

Please install.

Dave
--
John David Anglin	dave.anglin@bell.net

Attachment: allocatestack.d.txt
Description: Text document

Follow-Ups:
- Re: [PATCH] Fix stack memory protection on targets where the stack grows upward
  - From: Andreas Schwab
- Re: [PATCH] Fix stack memory protection on targets where the stack grows upward
  - From: Florian Weimer

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]