This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 01/13] posix: Consolidate Linux pause syscall
- From: Florian Weimer <fweimer at redhat dot com>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, libc-alpha at sourceware dot org
- Date: Fri, 12 May 2017 20:15:35 +0200
- Subject: Re: [PATCH 01/13] posix: Consolidate Linux pause syscall
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=fweimer at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 1A58F3D941
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1A58F3D941
- References: <1494611894-9282-1-git-send-email-adhemerval.zanella@linaro.org>
On 05/12/2017 07:58 PM, Adhemerval Zanella wrote:
+/* sparc64 defines __NR_pause, however it is not supported (ENOSYS).
+ Undefine so pause.c can use a correct alternative. */
+# ifdef __NR_pause
+# undef __NR_pause
+# endif
I think you can #undef unconditionally, there isn't a warning for that.
+ return SYSCALL_CANCEL (ppoll, 0, 0, 0, 0, 0);
I think some of the arguments should be NULL instead of 0.
I'm not completely sure if an empty ppoll without a timeout has the
required semantics, but I can't think of a reason why it would not work.
Thanks,
Florian