This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] resolv: Do not copy IPv4 addresses to IPv6 address array
- From: Florian Weimer <fweimer at redhat dot com>
- To: Andreas Schwab <schwab at linux-m68k dot org>
- Cc: GNU C Library <libc-alpha at sourceware dot org>, Carlos O'Donell <carlos at redhat dot com>
- Date: Tue, 4 Jul 2017 11:47:48 +0200
- Subject: Re: [PATCH] resolv: Do not copy IPv4 addresses to IPv6 address array
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=fweimer at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 1A0E48553F
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1A0E48553F
- References: <8113b7c9-b9a8-7157-f957-53853dc4e232@redhat.com> <87h8yt6yq5.fsf@linux-m68k.org>
On 07/03/2017 10:40 PM, Andreas Schwab wrote:
> On Jun 29 2017, Florian Weimer <fweimer@redhat.com> wrote:
>
>> Andreas, if I recall correctly, you wrote get_nsaddr.
>
> Yes, the BIND resolver in FreeBSD has the same function.
What do you think about the patch I posted?
> Their way to extend _res for IPv6 is worth looking at.
They put pointers to malloc'ed state directly into _res. We could od as
well, but it will cause problems if applications copy _res, so I went
for the more complex approach.
Thanks,
Florian