Re: [PATCH] resolv: Forward legacy name resolution function calls to NSS

[Carlos O'Donell <carlos at redhat dot com>]

On 07/04/2017 11:30 AM, Florian Weimer wrote:
> On 07/04/2017 05:17 PM, Carlos O'Donell wrote:
>> On 07/04/2017 11:05 AM, Florian Weimer wrote:
>>> The attached patch replaces the compat name lookup functions with calls
>>> to the matching NSS functions.  I think this is the right thing to do
>>> for now.  If this turns out to break NSS modules which assume that
>>> calling res_gethostbyname does not call into NSS in turn, we could
>>> probably add a more elaborate compat implementation based on nss_dns and
>>> nss_files, without actually duplicating their code.
>>>
>>> Comments?
>>
>> What is the purpose of the change?
> 
> The idea is not to ship unmaintained DNS packet parsing code.

That is a good goal.

> (The patch as posted lacks removal of the declarations from the
> include/resolv.h header.)

OK.

Overall the patch looks good, but we can't really tell if this is going
to cause problems in the wild.

Given that we have F27 about to freeze and release with 2.26, I think it
would be a good idea to wait for the release, put this patch into Rawhide,
and let it percolate to see if anything fails? Then come back and we can
put the patch into 2.27?

-- 
Cheers,
Carlos.