This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [RFC][PATCH v8 00/16][BZ 10871] Month names in alternative (nominative/genitive) case
- From: Rafal Luzynski <digitalfreak at lingonborough dot com>
- To: libc-alpha at sourceware dot org, Zack Weinberg <zackw at panix dot com>
- Date: Wed, 5 Jul 2017 02:15:37 +0200 (CEST)
- Subject: Re: [RFC][PATCH v8 00/16][BZ 10871] Month names in alternative (nominative/genitive) case
- Authentication-results: sourceware.org; auth=none
- References: <252786751.151540.1498643818058@poczta.nazwa.pl> <2a9007a5-260a-056a-4e41-b33e16bd65ec@panix.com>
- Reply-to: Rafal Luzynski <digitalfreak at lingonborough dot com>
3.07.2017 23:35 Zack Weinberg <zackw@panix.com> wrote:
>
>
> On 06/28/2017 05:56 AM, Rafal Luzynski wrote:
> > This is almost complete repost of my patches. The previous series was
> > posted on May 29. [1] There are not many changes in this set, mostly it
> > is rebase against the current master and applying some recent changes
> > like using locale_t instead of __locale_t [2].
>
> Having now read through the entire patch series, I would like to suggest
> that you squash patches 1, 4, 5, and 8 together into one patch that does
> the complete change for %OB, just as patch 9 does the complete change
> for %Ob. They are _logically_ all the same change and should be
> reviewed as a unit.
>
> zw
Thank you again for your review, Zack. I always meant that these patches
should be squashed before the final commit. I have split them only for
the easier review and to give the reviewers/committers choice which parts
will be accepted and which will be rejected. For example now we have
decided to reject the backward compatibility.
Regards,
Rafal