This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] x86-64: Align the stack in __tls_get_addr [BZ #21609]

On 07/06/2017 06:23 PM, Alexander Monakov wrote:
> On Thu, 6 Jul 2017, Carlos O'Donell wrote:
>> Option (b) has been chosen for this release, so that's what we're doing for
>> the release, but we can continue to discuss the optimization here.
>>
>> (1) Cost.
>>
>> No matter what you do it's extra instructions on the hot path forever.
> 
> What extra instructions on the hot path?  I don't see any.  There's no
> need to check stack alignment on the hot path -- only on the slow path.

Indeed, the x86-64 fast path is identical to the GCC-compiled version in
current master.

Florian
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]