This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCHv2] Fix float128 IFUNC relocations on ppc64le [BZ #21707]

Joseph Myers <joseph@codesourcery.com> writes:

> On Sat, 8 Jul 2017, Tulio Magno Quites Machado Filho wrote:
>
>> diff --git a/elf/Makefile b/elf/Makefile
>> index 201b328..b603e89 100644
>> --- a/elf/Makefile
>> +++ b/elf/Makefile
>> @@ -147,12 +147,13 @@ tests-static-normal := tst-leaks1-static tst-array1-static tst-array5-static \
>>  	       tst-tlsalign-static tst-tlsalign-extern-static \
>>  	       tst-linkall-static tst-env-setuid tst-env-setuid-tunables
>>  tests-static-internal := tst-tls1-static tst-tls2-static \
>> -	       tst-ptrguard1-static tst-stackguard1-static
>> +	       tst-ptrguard1-static tst-stackguard1-static \
>> +	       tst-tlsifunc-static
>>  
>>  tests := tst-tls9 tst-leaks1 \
>>  	tst-array1 tst-array2 tst-array3 tst-array4 tst-array5 \
>>  	tst-auxv
>> -tests-internal := tst-tls1 tst-tls2 $(tests-static-internal)
>> +tests-internal := tst-tls1 tst-tls2 tst-tlsifunc $(tests-static-internal)
>
> I'd expect these additions to need to be conditional on IFUNC support 
> (ifneq (no,$(multi-arch)), as already used in elf/Makefile) to avoid 
> problems on architectures lacking such support.

Fixed.  Thanks!

-- 
Tulio Magno
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]