This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] Added Samoan language locale for Samoa
- From: Mike FABIAN <mfabian at redhat dot com>
- To: Akhilesh Kumar <akhilesh dot k at samsung dot com>
- Cc: libc-alpha at sourceware dot org, pankaj dot m at samsung dot com
- Date: Tue, 11 Jul 2017 13:36:30 +0200
- Subject: Re: [PATCH v2] Added Samoan language locale for Samoa
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=mfabian at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 148ACC04B924
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 148ACC04B924
- References: <CGME20170711105623epcas5p205e886fcccf97c331f3439c0876f634d@epcas5p2.samsung.com> <1499770349-26411-1-git-send-email-akhilesh.k@samsung.com>
Akhilesh Kumar <akhilesh.k@samsung.com> wrote:
> [BZ #21710]
> Added Samoan language locale for Samoa
>
> +% Equivalent of AM PM
> +% AM PM
> +am_pm "<U0041><U004D>";/
> + "<U0050><U004D>"
> +%
There is still no translation for AM and PM.
Is it OK to use the English strings here?
[...]
> +LC_MONETARY
> +% https://en.wikipedia.org/wiki/ISO_4217
> +% WST
> +int_curr_symbol "<U0057><U0053><U0024><U0020>"
> +% https://en.wikipedia.org/wiki/Samoan_t%C4%81l%C4%81
> +% WS$
> +currency_symbol "<U0057><U0053><U0054>"
decoded:
LC_MONETARY
% https://en.wikipedia.org/wiki/ISO_4217
% WST
int_curr_symbol "WS$ "
% https://en.wikipedia.org/wiki/Samoan_t%C4%81l%C4%81
% WS$
currency_symbol "WST"
This seems wrong and does not agree with the comments, it should be:
int_curr_symbol "WST "
currency_symbol "WS$"
[...]
--
Mike FABIAN <mfabian@redhat.com>