This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Fix for bz14333 -- race between atexit() and exit()

From: Paul Pluzhnikov <ppluzhnikov at google dot com>
To: Joseph Myers <joseph at codesourcery dot com>
Cc: GLIBC Devel <libc-alpha at sourceware dot org>, Ricky Zhou <rickyz at google dot com>
Date: Wed, 12 Jul 2017 08:56:31 -0700
Subject: Re: [patch] Fix for bz14333 -- race between atexit() and exit()
Authentication-results: sourceware.org; auth=none
References: <CALoOobNCZqgvcLJhuJt5eSWseuTfHJ9oVsG9TpPvytyfzF56mg@mail.gmail.com> <alpine.DEB.2.20.1707111221040.845@digraph.polyomino.org.uk> <CALoOobMw+FNimtKqhO4cyayp8HGeGWO55veqKCD=fNoknreXkA@mail.gmail.com> <alpine.DEB.2.20.1707111900580.9395@digraph.polyomino.org.uk>

On Tue, Jul 11, 2017 at 12:01 PM, Joseph Myers <joseph@codesourcery.com> wrote:

> A patch fixing a bug should also include the tests for that bug.

Revised patch attached. Thanks.

2017-07-12  Paul Pluzhnikov  <ppluzhnikov@google.com>
            Ricky Zhou <rickyz@google.com>
            Anoop V Chakkalakkal <anoop.vijayan@in.ibm.com>

        [BZ #14333]
        * stdlib/cxa_atexit.c (__internal_atexit): Use __exit_funcs_lock.
        (__new_exitfn): Fail registration when we finished at_exit processing.
        * stdlib/on_exit.c (__on_exit): Likewise.
        * stdlib/exit.c (__exit_funcs_done): New variable.
        (__run_exit_handlers): Use __exit_funcs_lock.
        * stdlib/exit.h (__exit_funcs_lock, __exit_funcs_done): New
        declarations.
        * stdlib/Makefile (test-atexit-race, test-quick_at_exit-race)
        (test-__cxa_atexit-race): New tests.
        * stdlib/test-atexit-race-common.c: New.
        * stdlib/test-atexit-race.c: New.
        * stdlib/test-at_quick_exit-race.c: New.
        * stdlib/test-__cxa_atexit-race.c: New.

-- 
Paul Pluzhnikov

Attachment: glibc-bz14333-20170712.txt
Description: Text document

Follow-Ups:
- Re: [patch] Fix for bz14333 -- race between atexit() and exit()
  - From: Andreas Schwab

References:
- [patch] Fix for bz14333 -- race between atexit() and exit()
  - From: Paul Pluzhnikov
- Re: [patch] Fix for bz14333 -- race between atexit() and exit()
  - From: Joseph Myers
- Re: [patch] Fix for bz14333 -- race between atexit() and exit()
  - From: Paul Pluzhnikov
- Re: [patch] Fix for bz14333 -- race between atexit() and exit()
  - From: Joseph Myers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]