This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Don't all __access_noerrno with stack protector from __tunables_init [BZ #21744]
- From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- To: Florian Weimer <fw at deneb dot enyo dot de>, "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Mon, 17 Jul 2017 17:41:32 -0300
- Subject: Re: [PATCH] Don't all __access_noerrno with stack protector from __tunables_init [BZ #21744]
- Authentication-results: sourceware.org; auth=none
- References: <20170716191924.GA7226@gmail.com> <7643d65d-839e-a85d-8a4f-30eada595887@linaro.org> <CAMe9rOrU5Wp=bZgOY=91dyEJHjW6SJ5HknOeS_92pTxukpFrhA@mail.gmail.com> <874luag5n4.fsf@mid.deneb.enyo.de>
On 17/07/2017 17:39, Florian Weimer wrote:
> * H. J. Lu:
>
>> I don't think it works for Hurd.
Right, but I still think it would be better to make the access call
platform specific and call __access_noerrno for Hurd and issue
an inline syscall for Linux.
>
> Yes, generic code cannot use INTERNAL_SYSCALL_CALL. And it would have
> to be INLINE_SYSCALL_CALL to prevent the errno access, I think.
>
INLINE_SYCALL_CALL is the one that sets errno in fact.