This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [Patch] Fix nss/nss_test1.c compile with latest GCC
- From: Steve Ellcey <sellcey at cavium dot com>
- To: DJ Delorie <dj at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Fri, 21 Jul 2017 09:54:50 -0700
- Subject: Re: [Patch] Fix nss/nss_test1.c compile with latest GCC
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Steve dot Ellcey at cavium dot com;
- References: <xnr2xct3zw.fsf@greed.delorie.com>
- Reply-to: sellcey at cavium dot com
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On Wed, 2017-07-19 at 19:13 -0400, DJ Delorie wrote:
> Steve Ellcey <sellcey@cavium.com> writes:
> >
> > I think this is due to new error checking added to GCC and in this
> > case I think that GCC is correct in its error. We should
> > be using the default_pwd_data in this expression and not pwd_data.
> Correct, although no existing tests actually use that data, so the
> bug
> (and the fix) do not affect test results.
>
> >
> > This patch fixes the proglem, OK for checkin?
> I was going to check in the same patch... but my rawhide gcc didn't
> give
> a warning so I haddn't yet confirmed it.
>
> So LGTM :-)
>
> Thanks!
Since there haven't seen any objections to this I am going to go ahead
and check it in.
Steve Ellcey