This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/1] Removed reentrant data for LC_MONETARY
- From: Zack Weinberg <zackw at panix dot com>
- To: Akhilesh Kumar <akhilesh dot k at samsung dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Wed, 26 Jul 2017 11:09:13 -0400
- Subject: Re: [PATCH 1/1] Removed reentrant data for LC_MONETARY
- Authentication-results: sourceware.org; auth=none
- References: <CGME20170726035506epcas5p2f6ddd783d950c4e5e4a3a52c343fb2a9@epcas5p2.samsung.com> <1501041054-47225-1-git-send-email-akhilesh.k@samsung.com>
On Tue, Jul 25, 2017 at 11:50 PM, Akhilesh Kumar <akhilesh.k@samsung.com> wrote:
> [BZ #21821]
> * locales/ar_IN (LC_MONETARY) : Edit
> * locales/bhb_IN (LC_MONETARY): Edit
> * locales/bn_IN (LC_MONETARY) : Edit
> * locales/en_IN (LC_MONETARY) : Edit
> * locales/kn_IN (LC_MONETARY) : Edit
> * locales/kok_IN(LC_MONETARY) : Edit
> * locales/ks_IN (LC_MONETARY) : Edit
> * locales/mr_IN (LC_MONETARY) : Edit
> * locales/pa_IN (LC_MONETARY) : Edit
> * locales/sa_IN (LC_MONETARY) : Edit
> * locales/sd_IN (LC_MONETARY) : Edit
> * locales/tcy_IN(LC_MONETARY) : Edit
> * locales/ur_IN (LC_MONETARY) : Edit
This is not a proper ChangeLog entry. What we want is
* locales/ar_IN (LC_MONETARY): Copy from hi_IN.
* locales/bhb_IN: Likewise.
* locales/bn_IN: Likewise.
* locales/en_IN: Likewise.
* locales/kn_IN: Likewise.
* locales/kok_IN: Likewise.
* locales/ks_IN: Likewise.
* locales/mr_IN: Likewise.
* locales/pa_IN: Likewise.
* locales/sa_IN: Likewise.
* locales/sd_IN: Likewise.
* locales/tcy_IN: Likewise.
* locales/ur_IN: Likewise.
or
* locales/ar_IN, locales/bhb_IN, locales/bn_IN, locales/en_IN
* locales/kn_IN, locales/kok_IN, locales/ks_IN, locales/mr_IN
* locales/pa_IN, locales/sa_IN, locales/sd_IN, locales_tcy_IN
* locales/ur_IN
(LC_MONETARY): Copy from hi_IN.
The most important part is that you have to say *what you changed*.
"Edit" is not enough.
If you do not have the time or do not understand how to write proper
changelog entries, please just leave them out entirely. It is less
work for reviewers to write one from scratch than it is to fix up a
bad one.
> Signed-off-by: Akhilesh Kumar <akhilesh.k@samsung.com>
We don't use Signed-off-by. Please do not include this in future
patches, we don't want people browsing the revision history to be
confused.
zw