This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] Removed redundant data for LC_MONETARY
- From: Mike FABIAN <mfabian at redhat dot com>
- To: Carlos O'Donell <carlos at redhat dot com>
- Cc: "H.J. Lu" <hjl dot tools at gmail dot com>, Akhilesh Kumar <akhilesh dot k at samsung dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Wed, 26 Jul 2017 20:31:42 +0200
- Subject: Re: [PATCH v2] Removed redundant data for LC_MONETARY
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=mfabian at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 4CC8F769E5
- References: <CGME20170726075319epcas5p16a487cd5294afbfd37015bfd06af8657@epcas5p1.samsung.com> <1501055354-43092-1-git-send-email-akhilesh.k@samsung.com> <s9dlgnbh5b7.fsf@redhat.com> <CAMe9rOpsxkrCTENPL+_DqGVkxkPfGBA91gQ0Q1SubwrFbDq-9Q@mail.gmail.com> <d5b789f1-6910-7515-c755-2d77684a0edc@redhat.com>
Carlos O'Donell <carlos@redhat.com> さんはかきました:
> On 07/26/2017 01:01 PM, H.J. Lu wrote:
>> On Wed, Jul 26, 2017 at 3:15 AM, Mike FABIAN <mfabian@redhat.com> wrote:
>>> Akhilesh Kumar <akhilesh.k@samsung.com> wrote:
>>>
>>>> [BZ #21836]
>>>> * locales/ar_IN (LC_MONETARY) : Edit
>>>> * locales/as_IN (LC_MONETARY) : Edit
>>>> * locales/bhb_IN (LC_MONETARY): Edit
>>>> * locales/bn_IN (LC_MONETARY) : Edit
>>>> * locales/en_IN (LC_MONETARY) : Edit
>>>> * locales/gu_IN (LC_MONETARY) : Edit
>>>> * locales/kn_IN (LC_MONETARY) : Edit
>>>> * locales/kok_IN(LC_MONETARY) : Edit
>>>> * locales/ks_IN (LC_MONETARY) : Edit
>>>> * locales/ml_IN (LC_MONETARY) : Edit
>>>> * locales/mr_IN (LC_MONETARY) : Edit
>>>> * locales/or_IN (LC_MONETARY) : Edit
>>>> * locales/pa_IN (LC_MONETARY) : Edit
>>>> * locales/sa_IN (LC_MONETARY) : Edit
>>>> * locales/sd_IN (LC_MONETARY) : Edit
>>>> * locales/ta_IN (LC_MONETARY) : Edit
>>>> * locales/tcy_IN(LC_MONETARY) : Edit
>>>> * locales/te_IN (LC_MONETARY) : Edit
>>>> * locales/ur_IN (LC_MONETARY) : Edit
>>>
>>> committed.
>>>
>>
>> On Fedora/26, this caused:
>>
>> FAIL: stdlib/tst-strfmon_l
>>
>> error: locale te_IN.UTF-8, format "%i", value 1.23457e+06: mismatch
>> error: expected: "INR12,34,567.89"
>> error: actual: "INR 1,234,567.89"
>> error: locale te_IN.UTF-8, format "%n", value 1.23457e+06: mismatch
>> error: expected: "₹12,34,567.89"
>> error: actual: "₹ 1,234,567.89"
>> error: locale te_IN.UTF-8, format "%^i", value 1.23457e+06: mismatch
>> error: expected: "INR1234567.89"
>> error: actual: "INR 1234567.89"
>> error: locale te_IN.UTF-8, format "%^n", value 1.23457e+06: mismatch
>> error: expected: "₹1234567.89"
>> error: actual: "₹ 1234567.89"
>> error: locale te_IN.UTF-8, format "%i", value -1.23457e+06: mismatch
>> error: expected: "-INR12,34,567.89"
>> error: actual: "-INR 1,234,567.89"
>> error: locale te_IN.UTF-8, format "%n", value -1.23457e+06: mismatch
>> error: expected: "-₹12,34,567.89"
>> error: actual: "-₹ 1,234,567.89"
>> error: locale te_IN.UTF-8, format "%^i", value -1.23457e+06: mismatch
>> error: expected: "-INR1234567.89"
>> error: actual: "-INR 1234567.89"
>> error: locale te_IN.UTF-8, format "%^n", value -1.23457e+06: mismatch
>> error: expected: "-₹1234567.89"
>> error: actual: "-₹ 1234567.89"
>> error: locale bn_IN.UTF-8, format "%i", value 1.23457e+06: mismatch
>> error: expected: "INR 12,345,67.89"
>> error: actual: "INR 1,234,567.89"
>> error: locale bn_IN.UTF-8, format "%n", value 1.23457e+06: mismatch
>> error: expected: "₹ 12,345,67.89"
>> error: actual: "₹ 1,234,567.89"
>> error: locale bn_IN.UTF-8, format "%i", value -1.23457e+06: mismatch
>> error: expected: "-INR 12,345,67.89"
>> error: actual: "-INR 1,234,567.89"
>> error: locale bn_IN.UTF-8, format "%n", value -1.23457e+06: mismatch
>> error: expected: "-₹ 12,345,67.89"
>> error: actual: "-₹ 1,234,567.89"
>
> Mike,
>
> Can you confirm that you see these failures?
>
> For avoidance of doubt we should be running the full glibc testsuite
> to make sure the locales get tested with the associated APIs that use
> them and thus catch errors like those above (or adjust test data for
> the changes).
Yes, checking it.
--
Mike FABIAN <mfabian@redhat.com>