This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Enable unwind info in libc-start.c and backtrace.c
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Wilco Dijkstra <Wilco dot Dijkstra at arm dot com>, "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>
- Cc: nd <nd at arm dot com>, Andreas Schwab <schwab at suse dot de>
- Date: Wed, 9 Aug 2017 08:45:43 -0400
- Subject: Re: [PATCH] Enable unwind info in libc-start.c and backtrace.c
- Authentication-results: sourceware.org; auth=none
- References: <DB6PR0801MB205372EB7CB30BC3564DE1C083B20@DB6PR0801MB2053.eurprd08.prod.outlook.com> <mvmzibkr7kc.fsf@suse.de> <DB6PR0801MB20535546A6F95E36849C84FA83B20@DB6PR0801MB2053.eurprd08.prod.outlook.com> <DB6PR0801MB2053DFC14FB872257FCA400F838B0@DB6PR0801MB2053.eurprd08.prod.outlook.com>
On 08/09/2017 07:46 AM, Wilco Dijkstra wrote:
> After feedback on https://sourceware.org/ml/libc-alpha/2017-07/msg01010.html
> here is the updated patch:
>
> Add unwind info to __libc_start_main so that unwinding continues one
> extra level to _start. Similarly add unwind info to backtrace.
> Given many targets require this, do this in a general way and remove
> -funwind-tables (or -fexceptions - which is identical in C) from several
> target makefiles.
>
> ChangeLog:
> 2017-08-09 Wilco Dijkstra <wdijkstr@arm.com>
>
> * sysdeps/aarch64/Makefile: Build libc-start.c with -fexceptions.
> * csu/Makefile: Add -funwind-tables to libc-start.c.
> * debug/Makefile: Add -funwind-tables to backtrace.c.
> * sysdeps/aarch64/Makefile: Remove CFLAGS-backtrace.c.
> * sysdeps/arm/Makefile: Likewise.
> * sysdeps/i386/Makefile: Likewise.
> * sysdeps/m68k/Makefile: Likewise.
> * sysdeps/mips/Makefile: Likewise.
> * sysdeps/nios2/Makefile: Likewise.
> * sysdeps/sh/Makefile: Likewise.
> * sysdeps/sparc/Makefile: Likewise.
This looks god to me, but I'd like to know what machines you've tested on?
If you tested on aarch64, i386, and arm (v7), then I'd say you've done enough
to show it work on 64-bit and 32-bit for relevant machines.
--
Cheers,
Carlos.